Deprecate mysqli_stmt_init - #23209
Conversation
| @@ -31,12 +30,9 @@ require_once 'skipifconnectfailure.inc'; | |||
| echo $exception->getMessage() . "\n"; | |||
There was a problem hiding this comment.
echo $exception::class, ': ', $exception->getMessage(), "\n";If you want while you are on it.
There was a problem hiding this comment.
No, let's do that separately. This PR already has too many unrelated changes.
There was a problem hiding this comment.
please rebase this and regenerate the arginfo, it will use the new ZEND_STR_8_DOT_6 known string, see #23222
Do I have to modify the stub file again? |
no, just run the gen_stub script |
f6ecbac to
9f7c6c8
Compare
|
Adding whitespace, regenarating and removing whitespace worked. |
Ah, I guess that if the stub file hasn't changed it wouldn't run again by default, I just always use |
|
CI failure looks like it's something running tests in parallel exposed. I am on it. Edit: opened #23225 |
Co-authored-by: Máté Kocsis <kocsismate90@gmail.com>
4 participants
This was mostly replacing
mysqli_stmt_init+mysqli_stmt_preparewithmysqli_prepare.The unrelated changes are either fixing typos or removing dead code.